Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/duckdns: init module #294489

Merged
merged 2 commits into from
Nov 14, 2024
Merged

nixos/duckdns: init module #294489

merged 2 commits into from
Nov 14, 2024

Conversation

notthebee
Copy link
Contributor

Description of changes

Added a Systemd service for updating DuckDNS domains

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 9, 2024
@notthebee notthebee changed the title nixos/duckdns: init nixos/duckdns: init module Mar 9, 2024
@notthebee notthebee marked this pull request as ready for review March 9, 2024 12:32
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Mar 9, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 9, 2024
nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/duckdns.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/duckdns.nix Show resolved Hide resolved
nixos/modules/services/misc/duckdns.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/duckdns.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/duckdns.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/duckdns.nix Show resolved Hide resolved
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing the query string like this exposes the secret to all (unprivileged) processes on the system -- can we avoid that?

If not, please add a big warning in the option description.

@bjornfor
Copy link
Contributor

You updated at the same time I commented 😀

However, the secret is still visible in process listings.

@bjornfor
Copy link
Contributor

I think "curl -K ./secret_params.txt ..." where secret_params.txt contains lines of "-d key=value" is the way to go. "replace-secret" in nixpkgs might help with securely preparing the file. (Untested.)

@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jun 1, 2024
@notthebee notthebee requested a review from bjornfor October 26, 2024 12:15
@notthebee
Copy link
Contributor Author

Used the -K parameter and some shell redirection to hide the secrets in the process list

@notthebee notthebee requested a review from Scrumplex October 26, 2024 12:16
@bjornfor
Copy link
Contributor

Used the -K parameter and some shell redirection to hide the secrets in the process list

Thanks!

Please rebase / squash the commits and I can take another look. (I think those 11 commits are just fixups to the one "init" commit?)

@notthebee
Copy link
Contributor Author

Used the -K parameter and some shell redirection to hide the secrets in the process list

Thanks!

Please rebase / squash the commits and I can take another look. (I think those 11 commits are just fixups to the one "init" commit?)

Done :)

nixos/modules/services/misc/duckdns.nix Show resolved Hide resolved
nixos/modules/services/misc/duckdns.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/duckdns.nix Outdated Show resolved Hide resolved
@notthebee notthebee force-pushed the master branch 2 times, most recently from fc7e50b to 827351b Compare November 8, 2024 17:09
@notthebee notthebee requested a review from bjornfor November 8, 2024 17:09
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these small nit picks, LGTM

nixos/modules/services/misc/duckdns.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/duckdns.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 10, 2024
@notthebee
Copy link
Contributor Author

@bjornfor @h7x4 Are there any other changes I should make before this can be merged?

@Scrumplex Scrumplex merged commit 1d95cb5 into NixOS:master Nov 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants